Repository navigation
Conversation
Summary: Allow Ingest to select full validation for its resolved request, including an existing accepted request waiting on the same head. Reject the override once the request has left accepted. Persist the strategy before publishing, preserve explicit full requests during backlog coalescing, and honor the override through admission and CAS races. Strategy updates retain the original acceptance event and timestamp. The override stays on its selected request and adds no scheduling priority. Test Plan: TestIngestFullPreservesAcceptanceHistory verifies the real log materializer keeps the original acceptance; TestIngestFullRejectsStartedOrTerminalRequest covers ineligible requests; TestProcessForcedFullRequest covers newer heads, occupied capacity, and admission/supersession races. Run locally: ./tool/bazel test //stovepipe/controller:go_default_test //stovepipe/controller/process:go_default_test //service/stovepipe/server/mapper:go_default_test //service/stovepipe/server/handler:go_default_test //stovepipe/core/requestlog:go_default_test --test_output=errors Formatting, lint, dependency tidiness and Gazelle consistency checked with make fmt lint check-tidy check-gazelle. Revert Plan: Revert this PR. API Changes: Add the optional force_full boolean to IngestRequest. Omission preserves ordinary ingestion. Forcing a request past accepted returns InvalidArgument.
mnoah1
marked this pull request as ready for review
November 12, 2026 20:59
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
November 12, 2026 20:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Older branches, such as staging test branches, can develop a large gap between the last validated commit and the current head.
In these cases, it can make more sense to trigger a full repository run at the latest head.
What?
Add
force_fullto ingest to select the full-repository strategy for the request at the current head. This also updates an existing accepted request for that head and preserves it through coalescing when newer heads arrive. The override applies only to that request; ingest returnsInvalidArgumentif it has already left accepted.Test Plan
Controller, process, mapper, RPC handler and request-log suites passed, covering forced ingestion, coalescing, admission races, ineligible requests and preserved acceptance history.
make fmt lint check-tidy check-gazellepassed.Revert Plan
Revert this PR.