Repository navigation
fix(aws-marketplace): check the container license's uncounted usage entitlement so every replica turns Enterprise on - #9996
Merged
Conversation
…ntitlement so every replica turns Enterprise on
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; the latest change fixes the log message collision without losing AWS’s explanation. SummaryThe PR switches license checks to the uncounted
No new actionable issues were found in the changes since the previous review. Reviews (2) · Last reviewed commit: "fix(aws-marketplace): keep the license c..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AWS::Marketplace::Usage(unitNone) instead of the contract dimension. In a real subscription, AWS grants the contract dimension as a counted entitlement (Unit: Count, one per license bought): aUnit: Nonecheckout of it returnsNoEntitlementsAllowed, and a counted checkout gives the unit to the first replica only. The usage entitlement is on every Marketplace license while its agreement is active, isn't counted, and every replica can check it out.AccessDeniedException) now logs AWS's error text, which names the fix. That covers a missing IAM permission and the other case we hit: License Manager never set up in the buyer account (service-linked role missing).Type of Change
Testing
AWS::Marketplace::Usage/Nonesucceeds, repeatedly.enterprise_license/NonereturnsNoEntitlementsAllowed.NoEntitlementsAllowed.AccessDeniedException(service role not found).container-license.test.ts: 11 tests pass. The request-shape and restart tests fail on the previous code.Checklist
test-auditauthoring gate)