Skip to content

fix(aws-marketplace): check the container license's uncounted usage entitlement so every replica turns Enterprise on - #9996

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/aws-marketplace-usage-entitlement
Nov 13, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/aws-marketplace-usage-entitlement

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The container license check now checks out AWS::Marketplace::Usage (unit None) instead of the contract dimension. In a real subscription, AWS grants the contract dimension as a counted entitlement (Unit: Count, one per license bought): a Unit: None checkout of it returns NoEntitlementsAllowed, and a counted checkout gives the unit to the first replica only. The usage entitlement is on every Marketplace license while its agreement is active, isn't counted, and every replica can check it out.
  • A refused check (AccessDeniedException) now logs AWS's error text, which names the fix. That covers a missing IAM permission and the other case we hit: License Manager never set up in the buyer account (service-linked role missing).
  • The Marketplace values profile documents that one-time License Manager setup. Chart bumped to 1.11.18.

Type of Change

  • Bug fix

Testing

  • Verified against a real subscription on a test EKS cluster with the IRSA role from the prerequisites template:
    • AWS::Marketplace::Usage / None succeeds, repeatedly.
    • enterprise_license / None returns NoEntitlementsAllowed.
    • The second counted checkout returns NoEntitlementsAllowed.
    • Before License Manager was set up, the check returned AccessDeniedException (service role not found).
  • container-license.test.ts: 11 tests pass. The request-shape and restart tests fail on the previous code.
  • biome check on the changed files.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ntitlement so every replica turns Enterprise on
@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 13, 2026 9:06am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the latest change fixes the log message collision without losing AWS’s explanation.

Summary

The PR switches license checks to the uncounted AWS::Marketplace::Usage entitlement so every replica can enable Enterprise.

  • Marketplace replicas can check the active license without using a counted unit.
  • License check failures now point operators to the needed account setup.

No new actionable issues were found in the changes since the previous review.

Reviews (2) · Last reviewed commit: "fix(aws-marketplace): keep the license c..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 96c4b0b into staging Nov 13, 2026
88 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 616bba11 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant