Repository navigation
Review and replace complex - #16743
Merged
Merged
Conversation
- Replace most instances of `_typeshed.ComplexInt` (as a marker that the exact type needs to be checked). - Replace a few instances with `complex | float | int` where all types are accepted. - Left a few instances that were either already an union with `float` and/or `int` or only accept `complex`. Part of python#16059
This comment has been minimized.
This comment has been minimized.
Should fix CI
This comment has been minimized.
This comment has been minimized.
3 of 7 tasks
jorenham
reviewed
Nov 9, 2026
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Nov 11, 2026
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
complex | float | intwhere all types are accepted.complexis accepted or returned.complexis already used in an union withfloatandint.Part of #16059